Bugfix/ios lib path and graal jni config #840
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR fixes the iOS static library export path and updates the GraalVM JNI configuration for improved consistency and correctness.
- Updated version bump guide to include the new version file.
- Modified iOS paths header to correct the library file path.
- Revised JNI configuration JSON and removed the unused hashCode JNI binding.
- Updated Bootstrap to use the new version constant and removed an obsolete dependency.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| versionBumpGuide.txt | Added reference to the new version file. |
| src/lifecycle/paths.h | Changed the iOS Graal native image path to remove the JVM_DIRECTORY prefix. |
| src/jvm_wrapper/kotlin_callable_custom.h | Removed the hashCode JNI method binding. |
| kt/plugins/godot-gradle-plugin/src/main/resources/godot/gradle/godot-kotlin-graal-jni-config.json | Renamed and added JNI configuration methods. |
| kt/godot-library/godot-core-library/src/main/kotlin/godot/runtime/Bootstrap.kt | Updated version retrieval to use the new constant. |
| kt/godot-library/godot-core-library/build.gradle.kts | Removed dependency on godot-build-props. |
| kt/common/src/main/kotlin/godot/common/Version.kt | Introduced the GODOT_KOTLIN_VERSION constant. |
Comments suppressed due to low confidence (1)
src/lifecycle/paths.h:39
- Consider adding a brief comment explaining the removal of the JVM_DIRECTORY prefix for IOS_GRAAL_NATIVE_IMAGE_FILE to clarify the rationale behind this bugfix for future maintainers.
static constexpr const char* IOS_GRAAL_NATIVE_IMAGE_FILE {"usercode.a"};
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes graalVM native-image JNI config and ios static lib export